-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A bunch of assorted patches related to socket activation feature (part 1) #6873
Conversation
f8a6f20
to
b1b755f
Compare
7515d28
to
e9c6852
Compare
e9c6852
to
0e428ed
Compare
0e428ed
to
53c49f5
Compare
53c49f5
to
7a17b5e
Compare
79c60c8
to
f4454d2
Compare
f4454d2
to
5d15802
Compare
5d15802
to
c855197
Compare
49a02e9
to
691d413
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
thanks for the patches, I'm fine with all the changes, ACK.
bye,
Sumit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in SYSTEMD: removed unneeded capabilities
commit message in CAP_SET?ID
. Otherwise ack.
I meant to denote both |
Code makes no difference handling '--socket-activated' and '--dbus-activated', it only makes things more obscure. Moreover, on a systemd enabled system, dbus activation actually starts systemd service anyway, so there is really no big difference.
since implicit files provider can't be enabled by default anymore. Resolves: SSSD#5022
This patch removes capabilities that aren't needed at all. Some (if not all) of remaining capabilities can be probably avoided with proper code changes, but currently those are needed. Examples (not limiting) of those caps usage: - CAP_DAC_OVERRIDE (@additional_caps@): access to /var/log/sssd, to /var/lib/sss/pipes/private/* (sssd:sssd owned sbus-monitor/dp sbus sockets) - CAP_CHOWN: `chown_debug_file()` in case of monitor activation - CAP_SETUID/CAP_SETGID: drop privs in case of monitor activation, switch_creds (in particular, sssd_kcm executing krb5_child for ticket renewal) - CAP_FOWNER: chmod(mem-cache) It's not that clear about 'CAP_KILL'. When 'sssd_be' terminates child process, it either still runs under root (so uid matches and no caps needed) or it dropped privs already and have lost CAP_KILL anyway. Another thing is 'monitor' signalling responders and providers that could be running under 'sssd' while 'monitor' itself runs under 'root'.
This allows to remove CAP_FOWNER.
'PermissionsStartOnly' is deprecated but used for consistency with other unit files.
9732dd3
to
944a633
Compare
Done. |
Ah, I did not get that :-) |
Pushed PR: #6873
|
No description provided.